We had decided to not change anything in the behaviour right now as peers who don't have access to the content of a page should not give feedback any way. If someone does need to give feedback and their institution doesn't allow peers to see the page content, they can share the page without the role restriction in place.
This work here only fixes that there is no error message any more. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1959613 Title: Problem with annotation feedback and draft feedback Status in Mahara: In Progress Bug description: Problem: Person A creates a SmartEvidence collection and has an annotation block on a page Person B adds a draft comment to it Person A requests the comment to be made public Person B gets an email and follows the link -- gets error [WAR] e2 (artefact/lib.php:353) Artefact type mismatch. You are trying to use this annotation as a comment. Call stack (most recent first): ArtefactType->__construct() at /../htdocs/artefact/comment/lib.php:193 ArtefactTypeComment->__construct() at /../htdocs/view/view.php:563 To test: 1 Set up new site 2 Go to Plugin Extensions page and activate annotation 3 Edit 'No institution' and allow SmartEvidence 4 Create accounts via CSV 5 Log in as Person A and create a page 6 Create a collection with a SmartEvidence option chosen and add page to it 7 Share the collection to Person B with special role Peer 8 Go to the collection's SmartEvidence page and add annotation to one of the dots 9 Log in as Person B and go to the collection SmartEvidence page and click on the circle dot 10 Leave some feedback and turn 'Mark public' to No - the feedback should have "This feedback is private." 11 Log in as Person A and go to the page itself in the collection and click on Feedback (1) link in annotation block 12 In the modal click the 'Make public' button - you should see "A message has been sent to Person B to request that the feedback be made public." 13 Log in as Person B and go to the page itself in the collection - you see "You cannot see the content on this page because it does not require a peer assessment." 14 Go to your inbox and see "Request to change private feedback to public" 15 Click the 'Annotation' link in the email and get the error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1959613/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
