Reviewed: https://reviews.mahara.org/c/mahara/+/12671 Committed: https://git.mahara.org/mahara/mahara/commit/9c286ff4c0b8eb261b0872d8f501aa8557fab18a Submitter: "Robert Lyon <[email protected]>" Branch: 22.04_DEV
commit 9c286ff4c0b8eb261b0872d8f501aa8557fab18a Author: Gold <[email protected]> Date: Thu Apr 28 13:11:52 2022 +1200 Bug 1970680: Only update if lti_assessment table exists Testing: Install an older Mahara without LTI 1.1, the 'lti' module installed. Update to the latest version with this patchset included. Change-Id: Ib08878373eba41c238d60b2718c44bd3cb6fd8a6 Signed-off-by: Gold <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1970680 Title: Upgrade fails when LTI not installed Status in Mahara: Fix Committed Status in Mahara 20.10 series: Fix Committed Status in Mahara 21.04 series: Confirmed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Committed Bug description: While upgrading a test site on Mahara 21.x that did not have LTI (1.1) the upgrade fails. Tracked this to an upgrade step in htdocs/lib/db/upgrade.php This version resolved the issue: if ($oldversion < 2021042718) { $table = new XMLDBTable('lti_assessment'); if (table_exists($table)) { log_debug("Make sure groups associated with LTI assessment have 'submittableto' set to true"); execute_sql(" UPDATE {group} SET submittableto = 1 WHERE id IN ( SELECT foo.id FROM ( SELECT g1.id FROM {lti_assessment} l JOIN {group} g1 ON g1.id = l.group WHERE g1.submittableto = 0 ) AS foo )"); } } Mitigation, if someone is in the middle of an update: Install the LTI module. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1970680/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
