Reviewed: https://reviews.mahara.org/c/mahara/+/12696 Committed: https://git.mahara.org/mahara/mahara/commit/5a454cd96f56aeb068c564628560275b84bd935f Submitter: "Robert Lyon <[email protected]>" Branch: 20.10_DEV
commit 5a454cd96f56aeb068c564628560275b84bd935f Author: Robert Lyon <[email protected]> Date: Mon May 2 10:35:05 2022 +1200 Bug 1971110: Error with title underscore Needs to URl encoded Change-Id: I229335f5c06f54019ec6eb5dae7f8a3291993bb4 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 771dab63b9e95c9ca0a97bad74d3078213902e86) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971110 Title: Adding block with underscore can cause problems Status in Mahara: Fix Committed Status in Mahara 20.10 series: Fix Committed Status in Mahara 21.04 series: Fix Committed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Committed Bug description: The following test will give an error: 1) Create a new page 2) Add a new block 3) Change the 'Placeholder' title to 'Text_block' 4) Click on the Content type option 'Text' 5) Get an error like this: Invalid page control action: id_X_new_1_blocktype_text_title_Text_block The problem is the underscore in the title clashes with code that wants to work out what blocktype action is happening. What we need to do is have the all the underscores in the title be turned into a url encoded values To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971110/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
