Hi Richard, Thanks for taking a look.
We run the minaccept on all changes which has shown the flaw in the processing code per my suggestion. We haven't changed any version numbers, they are different based on last changes to the respective files on 21.10_STABLE: htdocs/lib/db/upgrade.php: https://git.mahara.org/mahara/mahara/-/commit/11be0ecdbfa2dadcc3f2861006a840c0774a07ec (2021080215) htdocs/lib/version.php: https://git.mahara.org/mahara/mahara/-/commit/797a3743980c96a7579e43e0f271f2298c8a9193 (2021080220) I believe the issue is the minaccept assumes that there will be 1 or 2 point increase with an upgrade change which hasn't happened since 2021080215 on 21.10 branch. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1988840 Title: minaccept test fails on 2110_STABLE (21.10.04) Status in Mahara: Incomplete Bug description: make: *** [minaccept] Error 1 Looks like minaccept found some issues: Array ( [0] => Running minimum acceptance test... [1] => Bumping htdocs/lib/version.php... [2] => Old version: 2021080209 [3] => New version: 2021080220 [4] => New htdocs/lib/db/upgrade.php: 2021080211 [5] => New htdocs/lib/db/upgrade.php: 2021080212 [6] => New htdocs/lib/db/upgrade.php: 2021080213 [7] => New htdocs/lib/db/upgrade.php: 2021080214 [8] => New htdocs/lib/db/upgrade.php: 2021080215 [9] => ERROR: Version in htdocs/lib/version.php should match version of last new section in htdocs/lib/db/upgrade.php ) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1988840/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
