Reviewed: https://reviews.mahara.org/c/mahara/+/12962 Committed: https://git.mahara.org/mahara/mahara/commit/5b36091ebf3ea11a0890ed18b0c434b649dfe311 Submitter: "Doris Tam <[email protected]>" Branch: main
commit 5b36091ebf3ea11a0890ed18b0c434b649dfe311 Author: Gold <[email protected]> Date: Tue Jun 28 10:11:31 2022 +1200 Bug 1976432: PHP 8 Compatibility: webservice Still a WIP as there is a question around session_get_instance(). The function doesn't exist. Odds are that this code has never been hit as there are no bug reports. This leads me to think that this should be a stand alone bug report. Will leave this as a WIP until a decision is made on that though. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/webservice/lib.php#L1251 Signed-off-by: Gold <[email protected]> Change-Id: If0c2e22e850e77536a358dbd71dc68f5ddd10f00 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1976432 Title: PHP 8 Compatibility: webservice Status in Mahara: Fix Committed Bug description: This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1. The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools. This bug tracks files in the webservice directory. Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1. https://phpstan.org/ https://github.com/phan/phan To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1976432/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
