Reviewed: https://reviews.mahara.org/c/mahara/+/13183 Committed: https://git.mahara.org/mahara/mahara/commit/2bafdde76faf597127e9d21231f781bcfa72b93a Submitter: "Doris Tam <[email protected]>" Branch: main
commit 2bafdde76faf597127e9d21231f781bcfa72b93a Author: Robert Lyon <[email protected]> Date: Wed Sep 28 14:48:50 2022 +1300 Bug 1991031: Consolidate the checking from signoff/verify To one class/function Change-Id: Ia4fc012f61c139538f7a548f45d29535b3359d1f Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991031 Title: signoff/verify have two ways to work out signable/verifiable status Status in Mahara: Fix Committed Bug description: One is being used on the progress completion page, eg the $view->get_progress_action('owner') And the other is being used on individual pages, eg the ArtefactTypePeerassessment::is_signable($view, false) Both are lacking some things we need to check for We need to consolidate this down to one function that can be used in both places To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991031/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
