Reviewed: https://reviews.mahara.org/c/mahara/+/13549 Committed: https://git.mahara.org/mahara/mahara/commit/62c3449c4bd096fdee1f8266a366dc876f2bc0a2 Submitter: "Robert Lyon <[email protected]>" Branch: main
commit 62c3449c4bd096fdee1f8266a366dc876f2bc0a2 Author: Gold <[email protected]> Date: Mon Dec 12 14:48:48 2022 +1300 Bug 1999350: Submissions not showing if wwwroot is not set Catch wwwroot resolving to '/' and strip it from the path for $piertables_js Signed-off-by: Gold <[email protected]> Change-Id: Ib66a461622441feac26c259275dd100a90d26e28 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999350 Title: Submissions not showing if wwwroot is not set Status in Mahara: Fix Committed Bug description: If $cfg->wwwroot is not set and wwwroot in the config table is also not set then the path to piertables.js is prefixed with a "/". When this is added to $js in htdocs/module/submissions/src/Controller.php it ultimately ends up with an extra "/" after it is rendered in the template. This results in the browser seeing this as a protocoless URL and failing to resolve the host. To test: Stand up a site without $cfg->wwwroot set. Ensure 'wwwroot' is empty in the config table in the database. Create a Group such that submissions can be made to it. As an account that can submit to that Group create a page or collection and submit it to the Group. As an account that can view Group submissions click through to the Submissions page for the Group. You will note that the submission is not visible. If you view the page source and search for piertables.js you will see the path prefixed with "//". If you open your browser devtools, on the network tab you will see the file does not report as succeeding to load. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999350/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
