Reviewed: https://reviews.mahara.org/651 Committed: http://gitorious.org/mahara/mahara/commit/4cc1cd2492fe8f48976237a43124d56bf1080d8b Submitter: Hugh Davenport ([email protected]) Branch: master
commit 4cc1cd2492fe8f48976237a43124d56bf1080d8b Author: Eugene Venter <[email protected]> Date: Wed Sep 7 14:20:47 2011 +1200 auth/user.php: logout - fix user session db delete Bug #826453 Change-Id: I1e6c102b67ad0342a1d91494e84f74617722db93 Signed-off-by: Eugene Venter <[email protected]> -- You received this bug notification because you are a member of Mahara Core, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/826453 Title: Code to delete session id on logout is not triggered Status in Mahara ePortfolio: Confirmed Bug description: See https://reviews.mahara.org/#change,573 As Brian King noted, there is a bug in the $USER->logout() function that calls table_exists on a string rather than an XMLDBTable object. What's worse is that this code in logout() doesn't really serve any useful purpose. It is trying to delete a record of the user's session id when the user logs out, but because most of the time ddl.php is not included at this point, it won't be triggered. We should either include ddl.php explicitly, so it succeeds, or else maybe remove that code altogether. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/826453/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-core Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-core More help : https://help.launchpad.net/ListHelp
