Reviewed: https://reviews.mahara.org/713 Committed: http://gitorious.org/mahara/mahara/commit/0e1a0a2d2ea7c058f3250ba726ee704f0f0dc61a Submitter: Richard Mansfield ([email protected]) Branch: master
commit 0e1a0a2d2ea7c058f3250ba726ee704f0f0dc61a Author: Richard Mansfield <[email protected]> Date: Tue Sep 20 14:13:34 2011 +1200 Hide upload form when group files tab disables it (bug #854369) When selecting files for a block, the filebrowser "owner" tabs (my files, group files, etc.) are supposed to determine whether the upload form is displayed. However, when browsing group files, the tab upload rules are overridden by code introduced in commit 3ed6f3390c to show/hide the upload form depending on the group folder permissions. So when configuring a block within a personal view, the upload form should be hidden when browsing group files, but it's not hidden when the user has permission to edit the selected group folder. This patch ensures the filebrowser js remembers the state of the upload permission granted by the selected tab, and doesn't override that status when changing to a folder with different group edit permissions. Change-Id: I673815e17175508fc9d90e78b9e0a25e11831935 Signed-off-by: Richard Mansfield <[email protected]> -- You received this bug notification because you are a member of Mahara Core, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/854369 Title: Upload form not hidden correctly when selecting group files in a block Status in Mahara ePortfolio: Fix Committed Bug description: When selecting files for a block, the filebrowser "owner" tabs (my files, group files, etc.) are supposed to determine whether the upload form is displayed. However, when browsing group files, the tab upload rules are overridden by code to show/hide the upload form depending on the group folder permissions (introduced in commit 3ed6f3390c60de8f34dab3a4720272e6bd6cf21d). So for example, when configuring a block within a personal view, the upload form should always be hidden when browsing group files, but it's not hidden when the user has permission to edit the selected group folder. The problem is that the filebrowser javascript doesn't remember whether the currently selected tab allows uploads. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/854369/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-core Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-core More help : https://help.launchpad.net/ListHelp
