Reviewed: https://reviews.mahara.org/785 Committed: http://gitorious.org/mahara/mahara/commit/0043cc8322c59ebd37bf12e0b07372bcdc755f21 Submitter: Richard Mansfield ([email protected]) Branch: master
commit 0043cc8322c59ebd37bf12e0b07372bcdc755f21 Author: Hugh Davenport <[email protected]> Date: Wed Oct 12 14:38:22 2011 +1300 Fix issue when param_... functions have default of null Bug #872619 Regression from 79810c3d321b012df0b86a63459cc5de1cfd6e6f Basically, a default parameter of null was given, then trim was called, which made it into the string '' which then failed the test is_null in the files it was used. This reorders the functions so that the trim is called after the test to see whether the default should be used. This means that the default value is never trimmed, and can be null. One exception to this, is the param_boolean which doesn't test to see whether it is the default that is returned, so a check is made first to see whether it is null. Change-Id: I66d7253a8414dec7eb3ea67ebd363ea068a32012 Signed-off-by: Hugh Davenport <[email protected]> -- You received this bug notification because you are a member of Mahara Core, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/872619 Title: Users cannot access own journal unless multiplejournals enabled Status in Mahara ePortfolio: Triaged Bug description: a users journal is currently inaccessible to them until they choose multiple journals. the relevant object appears to not be getting the owner value populated. master linux postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/872619/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-core Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-core More help : https://help.launchpad.net/ListHelp
