Update of /cvsroot/mahogany/M/src/mail
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20451/src/mail
Modified Files:
MFCache.cpp
Log Message:
fixed one source of errors in message status updating code (showed up when new mail
was received during status update)
Index: MFCache.cpp
===================================================================
RCS file: /cvsroot/mahogany/M/src/mail/MFCache.cpp,v
retrieving revision 1.26
retrieving revision 1.27
diff -b -u -2 -r1.26 -r1.27
--- MFCache.cpp 12 Oct 2003 17:24:19 -0000 1.26
+++ MFCache.cpp 1 Jul 2004 18:31:15 -0000 1.27
@@ -215,6 +215,23 @@
}
+ /*
+ If we send this event from here we're in trouble because we're called
+ from mm_exists() notification and this event gets intermixed with other
+ c-client callbacks (notably flags update logic in OnMsgStatusChanged():
+ the simplest way to reproduce this bug is to send oneself a new message
+ and, before it is detected, flag a message in the inbox -- instant assert
+ failure) and, OTOH, the folder status will get updated anyhow as
+ currently UpdateStatus() will be called shortly after mm_exists() in any
+ case.
+
+ Nevertheless it is possible to imagine that it wouldn't and in this case
+ we'd need to restore this Send() here and try to fix the real bug in
+ status update code -- but for now just not generating this event here
+ makes everything work.
+ */
+#if 0
// if anybody has the status info for this folder, it must be updated
MEventManager::Send(new MEventFolderStatusData(folderName));
+#endif // 0
}
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Mahogany-cvsupdates mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mahogany-cvsupdates
