On Sat, 30 Nov 2002 15:39:15 +0100 Xavier Nodet <[EMAIL PROTECTED]> wrote:

XN> On Fri, 29 Nov 2002 01:54:29 +0100 (Romance Standard Time) Vadim Zeitlin 
<[EMAIL PROTECTED]> wrote:
XN> 
XN> >  Just some quick news: I introduced a new abstraction in the message viewer
XN> > code called "view filters".
XN> 
XN> Very nice !

 I think it was long over due. Implementing support for decryption of PGP
ASCII armored messages should now be a piece of cake. The only thing which
is really sad is that there is apparently no PGP library :-( GPGME doesn't
seem to compile under Win32 (it used to but now is broken if I'm to believe
their mailing list) without speaking about Mac and I haven't found any
other ones.

 Do you have any information about working with PGP/GPG? You know about it
more than me, apparently (well, I hope so!).

XN> But to make it work on MSVC6, I had to 

 Weird -- I *am* using MSVC6. I didn't do a full rebuild after my changes
however, maybe it somehow didn't recompile the relevant file.

XN> - replace 'class MTextStyle : public wxTextAttr{};' with 
XN>   'typedef wxTextAttr MTextStyle;' to avoid this kind of error
XN> 
XN> U:\src\M\src\modules\TextViewer.cpp(502) : error C2664: 'InsertText' : cannot 
convert 
XN> parameter 2 from 'class wxTextAttr' to 'const class MTextStyle &'
XN>         Reason: cannot convert from 'class wxTextAttr' to 'const class MTextStyle'
XN>         No constructor could take the source type, or constructor overload 
resolution was ambiguous
XN> 
XN> I guess there are other solutions, but this is the first I found...

 A better one would be to add a copy ctor. I'll do it.

XN> - include MTextStyle.h from ViewFilter.h, instead of the 
XN>   'class MTextStyle;' statement.

 The whole point of removing the original typedef was to allow to forward
declare this class, of course :-)

XN> One other point is that I think your values for the number of lines to
XN> look from the end are a little too small: e.g. the filters have no
XN> effect on the trailer in the M-Dev list... I added 10 to both (signature
XN> and trailer).

 I think the values are ok (although they will be configurable later anyhow
-- of course!) but we should ignore the trailing empty lines. At least for
the signatures it should really be enough -- I don't even want to think
about signatures more than 8 lines long!

 Regards,
VZ



-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
_______________________________________________
Mahogany-Developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mahogany-developers

Reply via email to