On Wed, 16 Jul 2003 10:24:07 +0200 (Romance Daylight Time) Vadim Zeitlin <[EMAIL PROTECTED]> wrote:
> On Sat, 28 Jun 2003 12:24:02 +0200 (CEST) Robert Vazan > <[EMAIL PROTECTED]> wrote: > > RV> I looked at renaming code and IMHO it isn't the right thing and it > will > RV> never be. I just don't like the idea that whenever I add some control > RV> with folder name, I have to add renaming code too. > > I'd like to question this fundamental assumption -- why not? Provided > that > there is one place in the code where we do it what's wrong with calling > some Profile::OnFolderRename(old, new)? Grand list of configuration entries that hold folder name is usable and I considered it along with other alternatives, but: - Module private configuration fragments it into multiple sublists - Renaming code is *added* while referencing code *changes* original code. Adding is easy to forget. - I noticed some script with embedded folder names in filters dialog - If Python will ever work, scripts might need identifiers (we are not going to rename in scripts) Anything more complicated than list of configuration entries is IMO extra effort and likely bug source. > Yes. BTW, in answer to your other message in this thread: plain text > config is not just a by product of using wxConfig, I do like using plain > text for everything as debugging is much simpler with it and I'd like to > keep it. The only problem is that it's so inefficient :-( It's not necessary to use strings at run-time, they are needed only for parsing and saving. Parsing 5KB shouldn't take too long. > To summarize, here is what I think about the proposal to add (3): > > + code will be simpler (and so less buggy) internally > - names in config won't correspond to the names on screen > - big changes needed, risk of new bugs > > Anything else? Folder tree and other code that uses visible names will need some support code to translate visible name to wxConfig group name. As far as group name is identifier, not visible name, most code will stay as is, because most of the time, it actually needs identifier. ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here: http://www.vmware.com/wl/offer/345/0 _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
