On Wed, 2 Jul 2003 12:57:07 +0200 Xavier Nodet <[EMAIL PROTECTED]> wrote:
XN> The problem I see is that wxFolderView::SelectInitialMessage() does both XN> of the following two things: XN> XN> - It calls back the wxFolderListCtrl through some methods like XN> SelectNextUnreadAfter() that try to lock the mutex. XN> XN> This prevents locking the mutex before calling SelectInitialMessage() XN> from the controler, as the call-backs would try to lock it again. XN> XN> - It directly calls some code that modifies the threading data XN> structures. A quite hidden such code is the line XN> XN> const HeaderInfo *hi = hil[idx]; XN> XN> at the end of SelectInitialMessage. XN> XN> My understanding is that the MVC pattern is broken here, It is and I agree that it shouldn't have been done like this. XN> and either the view should not call the data-structure modifying code XN> without using a call-back from the controler, or the entire XN> SelectInitialMessage() code should be in the controler, not the view. XN> XN> What do you think? I hope that it can still be fixed however -- and I've just tried to do it in the cvs. Could you please let me know if it helped? This is one of 2 bugs (second one is Nerijus' crash in the options dialog) which I want to fix before releasing "Claire" but I can hardly do anything about it -- it never happens here :-( so I have to rely on your help with it. Thanks, VZ ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here: http://www.vmware.com/wl/offer/345/0 _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
