On Sat, 13 Sep 2003 16:54:50 +0200 (CEST) Robert Vazan <[EMAIL PROTECTED]> wrote:
RV> On Fri, 5 Sep 2003 22:48:57 +0200 Vadim Zeitlin <[EMAIL PROTECTED]> RV> wrote: RV> RV> > I forgot RV> > about sendmail pipe but this was discussed in depth some (long) time ago RV> > and the existing code is correct (please don't change it!) in this RV> > respect, so you can just have a look at it. RV> RV> Actually, this is the only code that I have changed (so far...). I added RV> CRLF->LF conversion and I now get correct newlines in sendmail pipe, Smtp RV> after sendmail pipe, c-client's Smtp, and outbox file. This is really strange, I'm sure we did have this problem (with sendmail pipe) and fixed it... BTW, if we want to speak SMTP to a local MTA we must still have CRLF, not LFs. RV> > C-client is EOL-agnostic, RV> > AFAIK it doesn't do anything with the data. RV> RV> In unix_append_msg I read /* copy line, toss out CR from CRLF */. C-client RV> converts CRLF to LF when writing to Unix mailbox. Well, it is not called Unix mailbox format for nothing. But MBOX doesn't use this, does it? RV> My conclusion is that RV> c-client expects network newlines (CRLF) on input and always produces CRLF RV> on output. We must do CRLF<->LF conversion for all c-client calls. Yes, but it shouldn't be done twice (i.e. removing CRs just to insert them again later) because this can be expensive with big messages. Anyhow, what I wanted to say is that it doesn't change anything by itself and I think this is what you found, didn't you? RV> > Finally, Mahogany should use just LFs internally, always. The RV> > conversion should happen only when the data gets in and when it comes RV> > out. RV> RV> It depends where is out and where is in. According to what I describe RV> above, c-client is out. Yes, of course. Regards, VZ ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
