On Mon, 15 Mar 2004 16:01:19 -0800 Nerijus Baliunas <[EMAIL PROTECTED]> wrote:
NB> Update of /cvsroot/mahogany/M/src/modules NB> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10764/src/modules NB> NB> Modified Files: NB> Filters.cpp NB> Log Message: NB> isspace->wxIsspace, isalnum->wxIsalnum, and fixing warning "Filters.cpp:2051: warning: comparison is always true due to limited range of data type" I'm afraid it could have been a bad idea to change this if you did it automatically. When we deal with 8 bit chars (such as the actual contents of email messages) we really should be using isxxx() and not wxIsxxx(). NB> @@ -2049,5 +2049,5 @@ NB> const wxChar * const startSpaces = p; NB> p += NUM_SPACES; NB> - while ( *p < 128 && isspace(*p) ) NB> + while ( wxIsspace(*p) ) NB> p++; This change is wrong, you can't apply wxIsspace() (which is just the same as isspace() in ANI build) to characters outside 0..127 range. I do know that my code was wrong as well, fix committed. Regards, VZ ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
