On Wed, 4 Nov 2009 17:38:46 +0200 Nerijus Baliunas 
<neri...@users.sourceforge.net> wrote:

NB> On Thu, 10 Sep 2009 14:51:46 +0200 Vadim Zeitlin <va...@wxwindows.org> 
wrote:
NB> 
NB> VZ> NB> with latest svn when trying to view html message:
NB> VZ> NB> 
NB> VZ> NB> Program received signal SIGSEGV, Segmentation fault.
NB> VZ> NB> 0x323d6465 in ?? ()
NB> VZ> ...
NB> VZ> NB> (gdb) bt
NB> VZ> NB> #0  0x323d6465 in ?? ()
NB> VZ> NB> #1  0xb7fa3c47 in wxHtmlWindow::CreateLayout (this=0x8aaf000)
NB> VZ> NB>     at ../wxWidgets/src/html/htmlwin.cpp:693
NB> VZ> 
NB> VZ>  This is really strange, m_Cell may not be NULL here (it's checked for 
just
NB> VZ> above) so apparently it's a dangling pointer but I don't know how could
NB> VZ> this happen and there have definitely been no recent changes to wxHTML
NB> VZ> which could explain it.
NB> 
NB> I found the bad change by bitsecting:
NB> 
NB> Index: src/html/htmlwin.cpp
NB> ===================================================================
NB> --- htmlwin.cpp     (revision 61771)
NB> +++ htmlwin.cpp     (revision 61772)
NB> @@ -467,11 +467,8 @@
NB>      SetBackgroundImage(wxNullBitmap);
NB>  
NB>      m_Parser->SetDC(dc);
NB> -    if (m_Cell)
NB> -    {
NB> -        delete m_Cell;
NB> -        m_Cell = NULL;
NB> -    }
NB> +
NB> +    delete m_Cell;
NB>      m_Cell = (wxHtmlContainerCell*) m_Parser->Parse(newsrc);
NB>      delete dc;
NB>      m_Cell->SetIndent(m_Borders, wxHTML_INDENT_ALL, wxHTML_UNITS_PIXELS);
NB> 
NB> 61771 works, 61772 crashes.

 Thanks, I still don't see why exactly does it crash (AFAICS this can only
come from the fact that m_Cell is a dangling pointer while Parse() runs but
I don't see why/how does it use it) but if reverting this change fixes the
crash I'm going to do it. In fact already done in r62556.

 Thanks a lot for debugging this!
VZ

Attachment: pgpDy9Q7M1ChN.pgp
Description: PGP signature

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Mahogany-Developers mailing list
Mahogany-Developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mahogany-developers

Reply via email to