Author: srowen
Date: Sat May 31 11:18:53 2008
New Revision: 662059
URL: http://svn.apache.org/viewvc?rev=662059&view=rev
Log:
A few small tweaks suggested by FindBugs
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ByRescoreComparator.java
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/canopy/Canopy.java
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/KMeansReducer.java
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/matrix/SparseMatrix.java
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/utils/parameters/Parametered.java
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ByRescoreComparator.java
URL:
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ByRescoreComparator.java?rev=662059&r1=662058&r2=662059&view=diff
==============================================================================
---
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ByRescoreComparator.java
(original)
+++
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ByRescoreComparator.java
Sat May 31 11:18:53 2008
@@ -21,13 +21,12 @@
import org.apache.mahout.cf.taste.recommender.RecommendedItem;
import org.apache.mahout.cf.taste.recommender.Rescorer;
-import java.io.Serializable;
import java.util.Comparator;
/**
* <p>A simple [EMAIL PROTECTED]
org.apache.mahout.cf.taste.recommender.Rescorer} which always returns the
original score.</p>
*/
-final class ByRescoreComparator implements Comparator<RecommendedItem>,
Serializable {
+final class ByRescoreComparator implements Comparator<RecommendedItem> {
private final Rescorer<Item> rescorer;
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/canopy/Canopy.java
URL:
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/canopy/Canopy.java?rev=662059&r1=662058&r2=662059&view=diff
==============================================================================
---
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/canopy/Canopy.java
(original)
+++
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/canopy/Canopy.java
Sat May 31 11:18:53 2008
@@ -262,7 +262,7 @@
public void addPoint(Vector point) {
numPoints++;
for (int i = 0; i < point.cardinality(); i++)
- pointTotal.set(i, new Double(point.get(i) + pointTotal.get(i)));
+ pointTotal.set(i, point.get(i) + pointTotal.get(i));
}
/**
@@ -317,7 +317,7 @@
public Vector computeCentroid() {
Vector result = new SparseVector(pointTotal.cardinality());
for (int i = 0; i < pointTotal.cardinality(); i++)
- result.set(i, new Double(pointTotal.get(i) / numPoints));
+ result.set(i, pointTotal.get(i) / numPoints);
return result;
}
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/KMeansReducer.java
URL:
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/KMeansReducer.java?rev=662059&r1=662058&r2=662059&view=diff
==============================================================================
---
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/KMeansReducer.java
(original)
+++
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/KMeansReducer.java
Sat May 31 11:18:53 2008
@@ -31,7 +31,7 @@
public class KMeansReducer extends MapReduceBase implements
Reducer<Text, Text, Text, Text> {
- double delta = 0;
+ //double delta = 0;
public void reduce(Text key, Iterator<Text> values,
OutputCollector<Text, Text> output, Reporter reporter)
throws IOException {
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/matrix/SparseMatrix.java
URL:
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/matrix/SparseMatrix.java?rev=662059&r1=662058&r2=662059&view=diff
==============================================================================
---
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/matrix/SparseMatrix.java
(original)
+++
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/matrix/SparseMatrix.java
Sat May 31 11:18:53 2008
@@ -24,12 +24,7 @@
/**
* Doubly sparse matrix. Implemented as a Map of SparseVector rows
- */
-/**
- * @author jeff
- *
- */
-/**
+ *
* @author jeff
*
*/
@@ -50,8 +45,8 @@
public SparseMatrix(int[] cardinality, Map<Integer, SparseVector> rows) {
this.cardinality = cardinality.clone();
this.rows = new HashMap<Integer, Vector>();
- for (Integer row : rows.keySet())
- this.rows.put(row, rows.get(row).copy());
+ for (Map.Entry<Integer, SparseVector> entry : rows.entrySet())
+ this.rows.put(entry.getKey(), entry.getValue().copy());
}
/**
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/utils/parameters/Parametered.java
URL:
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/utils/parameters/Parametered.java?rev=662059&r1=662058&r2=662059&view=diff
==============================================================================
---
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/utils/parameters/Parametered.java
(original)
+++
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/utils/parameters/Parametered.java
Sat May 31 11:18:53 2008
@@ -167,7 +167,7 @@
private int longestName = 0;
private int numChars = 100; // a few extra just to be sure
- int distanceBetweenNameAndDescription = 4;
+ //int distanceBetweenNameAndDescription = 4;
private void recurseCount(Parametered parametered) {
for (Parameter parameter : parametered.getParameters()) {
