Author: srowen
Date: Tue Aug 26 18:05:04 2008
New Revision: 689314

URL: http://svn.apache.org/viewvc?rev=689314&view=rev
Log:
Fixed definition of fall-out, again

Modified:
    
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java

Modified: 
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java
URL: 
http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java?rev=689314&r1=689313&r2=689314&view=diff
==============================================================================
--- 
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java
 (original)
+++ 
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java
 Tue Aug 26 18:05:04 2008
@@ -83,6 +83,7 @@
       throw new IllegalArgumentException("Invalid relevanceThreshold: " + 
evaluationPercentage);
     }
 
+    int numItems = dataModel.getNumItems();
     RunningAverage precision = new FullRunningAverage();
     RunningAverage recall = new FullRunningAverage();
     RunningAverage fallOut = new FullRunningAverage();
@@ -131,7 +132,7 @@
           recall.addDatum((double) intersectionSize / (double) 
numRelevantItems);
           if (numRelevantItems < prefs.length) {
             fallOut.addDatum((double) (numRecommendedItems - intersectionSize) 
/
-                             (double) (prefs.length - numRelevantItems));
+                             (double) (numItems - numRelevantItems));
           }
 
           log.info("Precision/recall/fall-out: {} / {} / {}", new Object[] {


Reply via email to