Karl Wettin (JIRA) wrote:
-1 It occurred to me as I was copying and pasting the unit tests that many of the methods could indeed be refactored. Unfortunately, you must have forgotten to svn add the new MatrixTest superclass before you diffed <grin>. I do that all the time myself.[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]Karl Wettin updated MAHOUT-33: ------------------------------ Attachment: MAHOUT-33.patch This was spawned by MAHOUT-26 and by mistake this patch also contains the contents of that patch. I did not mean to do that, but there you go. I'm ready to commit that too. I did not check everything with my eyes, it was too much but everything pass though.Matrix tests share code that can be placed in an abstract class --------------------------------------------------------------- Key: MAHOUT-33 URL: https://issues.apache.org/jira/browse/MAHOUT-33 Project: Mahout Issue Type: Improvement Reporter: Karl Wettin Assignee: Karl Wettin Attachments: MAHOUT-33.patch
