On Apr 12, 2008, at 11:31 PM, Ted Dunning wrote:
On 4/12/08 8:22 PM, "Sean Owen" <[EMAIL PROTECTED]> wrote:
Hi guys, as I prepare to get my code into Mahout and I start looking
at the existing code I have a few questions...
- I take it we don't use @author tags?
Right.
We tend not to have them, b/c we like to stress community ownership.
Plus, over time, most files are rarely the work of one author.
- Any particular style convention we should follow? for example I see
some control statements without braces and I generally always put
them
on.
Sun standards. I don't think this case is specified, but I always
put htem
in.
There are Eclipse and Intellij styles at
http://cwiki.apache.org/MAHOUT/howtocontribute.html#HowToContribute-HelpfulResources
I think they pretty closely follow the Sun standards.
- How much should I or shouldn't I try to suggest some micro-tweaks
to
the code, like what I started on in MAHOUT-23?
There have been a number of debates in Lucene-Java land about
formatting. We generally avoid applying across the board formatting
patches retroactively, because it can make it even harder to apply
other patches. I tend to sometimes tweak things on specific files
that I am making other changes on as well.
What we should do is promote that all committers use the styles listed
on the Wiki for the Mahout project and then that way all new code will
be committed properly formatted.
-Grant
