OK, my first step when checking a patch is to see if there is unit
tests included and than flag it immediately, so no worries.
-Grant
On Apr 20, 2008, at 10:22 AM, julien nioche (JIRA) wrote:
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590766
#action_12590766 ]
julien nioche commented on MAHOUT-44:
-------------------------------------
I think the existing tests in TestSparseVector (testDot and
testZSum) cover that already.
Override zSum and dot for SparseVector
--------------------------------------
Key: MAHOUT-44
URL: https://issues.apache.org/jira/browse/MAHOUT-44
Project: Mahout
Issue Type: Improvement
Components: Matrix
Affects Versions: 0.1
Reporter: julien nioche
Assignee: Grant Ingersoll
Priority: Minor
Fix For: 0.1
Attachments: SparseVector.diff
revision 649163
The patch attached overrides the zSum() and dot() methods in
SparseVector. This is more efficient than relying on the methods
from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
