Hi Grant,
Well, the tests all run as advertised. The nature of the algorithm
itself is not obvious from the tests or the comments, and so it leaves
one needing to reverse-engineer that part. This might be simple if the
reader already understands Bayesian classifiers, but others (like me)
could use additional help. Perhaps more comments in the code and more
explanations in the wiki would be a useful adjunct or else I should buy
"ML for Dummies".
I also notice you use assertTrue() exclusively in your tests.
AssertEquals() gives more useful error messages - what was found vs.
what was expected - when it fails and you might want to consider using
that method in situations where you are comparing values.
I was able to get DummyObjectCollector committed in the brief SVN window
yesterday. Will you also be adding the lucene jar to the lib?
Jeff
Grant Ingersoll wrote:
Any thoughts on the rest of it?
-Grant
On May 1, 2008, at 11:55 AM, Jeff Eastman wrote:
Grant,
It looks like ASF is still having SVN problems as I cannot access it.
Once I can; however, I'd like to propose checking in your
utils.DummyObjectCollector and removing the others. You ok with that?
Jeff
