On May 11, 2008, at 6:07 PM, Jeff Eastman (JIRA) wrote:

- the pretty-printing rules are not those specified by ASF: the Java conventions with tabs replaced by 2 spaces vs. 4 spaces. The patch changes several of the existing canopy files formatting unnecessarily - the patch introduces @author tags which are not according to ASF policy. These were likely added by Eclipse but should be removed

Just to be clear, these are conventions we (Mahout/Lucene) adopt, not necessarily ASF policy. We can always remove/clean up before committing. The big thing about formatting is that we should try to keep it clean going in, but we shouldn't necessarily change it once it is in.

Reply via email to