Code police are back with a question: are we officially requiring Java
6 yet? I thought we had since Hadoop needs it but just checking.

A couple items I saw in the code...

- I think we should always use @Override where possible. In Java 6 it
can be used when implementing interface methods too. It's easy to
forget, but easy to add with the IDE over here, so I can take care of
it.

- If using a type with generic parameters, I think we should always
specify the generic type, even if it's <?>

- When an abstract class implements an interface, it does not have to
implement all the interface methods since it is abstract. So filling
in the abstract class with abstract methods that merely match the
remaining interface methods is redundant.

Reply via email to