I'd go for 1) and open a JIRA that reminds us to figure out to refactor to remove or minimize code duplication. With 2) this boolean-optimized option will be forgotten by others (other than by others)
Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch ----- Original Message ---- > From: Sean Owen <[email protected]> > To: [email protected] > Sent: Friday, January 9, 2009 5:54:15 PM > Subject: Re: Inactivity > > They're kinda ugly and duplicate some code... more of a rough proof of > concept. What do you think, should I... > > 1) just commit it after doing whatever light cleanup I can, or > 2) turn it over to you, to take this code into your project rather > than put it in the core > 3) farm it out to examples/ as an illustration of extending the basic > framework? > > On Fri, Jan 9, 2009 at 10:51 PM, Otis Gospodnetic > wrote: > > Sean, > > > > Do you think it would make sense to try and get those Boolean* versions of > various Taste classes in? > > > > 2371 12-31-49 16:00 BooleanPrefUser.java > > 5790 12-31-49 16:00 BooleanUserGenericDataModel.java > > 9809 12-31-49 16:00 BooleanPrefUserFileDataModel.java > > 3345 12-31-49 16:00 BooleanTanimotoCoefficientSimilarity.java > > 10501 12-31-49 16:00 BooleanUserGenericUserBasedRecommender.java > > 7237 12-31-49 16:00 FastSet.jav > > > > > > I'm using them in pre-production environment and they work well!
