[ 
https://issues.apache.org/jira/browse/MAHOUT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722360#action_12722360
 ] 

Jeff Eastman commented on MAHOUT-137:
-------------------------------------

You got bit by the fact that the reader is not creating a distinct instance and 
is reusing Canopy value. This makes all of the canopies identical and messes up 
the test. Here I'm making a copy of the canopy before adding it to the canopies 
list. The unit test now passes. Before committing these changes, you really 
ought to fix the code in examples too.

{noformat}
      try {
        Text key = new Text();
        Canopy value = new Canopy();
        while (reader.next(key, value)) {
          canopies.add(new Canopy(value.getCenter(),value.getCanopyId()));
        }
      } finally {
        reader.close();
      }
{noformat}

> Convert Clustering Algs to use Vector Writable
> ----------------------------------------------
>
>                 Key: MAHOUT-137
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-137
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 0.2
>
>         Attachments: MAHOUT-137.patch
>
>
> All M/R jobs should use Vector writable instead of encoding and decoding 
> strings.  We can have a separate utility that converts serialized GSON, 
> Strings, whatever into the appropriate vectors.  See MAHOUT-136 and 
> http://www.lucidimagination.com/search/document/6a55f260826fd77f/jira_commented_mahout_136_change_canopy_mr_implementation_to_use_vector_writable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to