Just walking through the code inspection results again and thought I'd
wonder at...
DenseVector / SparseVector define Iterators whose next() method can
never throw NoSuchElementException. In fact in one case it looks like
this was specifically disabled. This doesn't seem quite correct?
Seeing a lot of constructions like:
for (...) {
{
...
}
}
I'm going to remove the extra braces.
There are tons of non-private instance fields. I'm of the opinion that
an instance field should never be non-private -- maybe in the case of
a very simple value container inner class where performance is
important and you don't want to rely on JIT inlining getters or
setters. ... would there be objection to me trying to make as many
fields private as possible?
