Right now it's a for loop on i, but, the for loop also declares an
apparent index variable called j, which is not the index. A for loop
ought to be used when the index variable begins life at the start of
the loop, and of course the index variable declared in the for syntax
ought be the actual index variable of the loop. For those two reasons
it seems clearer to unpack this as a while loop and rename j.

I'm not going to block on the Iterator issues but those really ought
to be fixed.

On Tue, Oct 20, 2009 at 11:05 AM, Robin Anil <[email protected]> wrote:
>> i is being updated not j, the initial location is selected by a binary
> search(4 lines above).  And the function continues only if search returns
> correct.
>

Reply via email to