[jira] Commented: (MAHOUT-204) Better integration of Mahout matrix capabilities with Colt Matrix additions

[Shashikant Kore (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAHOUT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783577#action_12783577
 ] 

Shashikant Kore commented on MAHOUT-204:
----------------------------------------


I ran into compile troubles after updating the code. Following changes fixed 
the problem. Please see if this is the right fix.

{code}
Index: 
matrix/src/main/java/org/apache/mahout/jet/random/sampling/RandomSampler.java
===================================================================
--- 
matrix/src/main/java/org/apache/mahout/jet/random/sampling/RandomSampler.java   
    (revision 885339)
+++ 
matrix/src/main/java/org/apache/mahout/jet/random/sampling/RandomSampler.java   
    (working copy)
@@ -170,7 +170,7 @@
     int chunkSize = Integer.parseInt(args[3]);
     int times = Integer.parseInt(args[4]);

-    test(n, N, low, chunkSize, times);
+    //test(n, N, low, chunkSize, times);
     //testNegAlphaInv(args);
   }

Index: 
matrix/src/main/java/org/apache/mahout/matrix/matrix/objectalgo/Sorting.java
===================================================================
--- 
matrix/src/main/java/org/apache/mahout/matrix/matrix/objectalgo/Sorting.java    
    (revision 885339)
+++ 
matrix/src/main/java/org/apache/mahout/matrix/matrix/objectalgo/Sorting.java    
    (working copy)
@@ -52,12 +52,10 @@
   /** A prefabricated mergesort. */
   public static final Sorting mergeSort = new Sorting() { // override 
quicksort with mergesort

-    @Override
     protected void runSort(int[] a, int fromIndex, int toIndex, IntComparator 
c) {
       org.apache.mahout.matrix.Sorting.mergeSort(a, fromIndex, toIndex, c);
     }

-    @Override
     protected void runSort(int fromIndex, int toIndex, IntComparator c, 
org.apache.mahout.matrix.Swapper swapper) {
       GenericSorting.mergeSort(fromIndex, toIndex, c, swapper);
     }

{code}



> Better integration of Mahout matrix capabilities with Colt Matrix additions
> ---------------------------------------------------------------------------
>
>                 Key: MAHOUT-204
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-204
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.3
>            Reporter: Grant Ingersoll
>             Fix For: 0.3
>
>         Attachments: MAHOUT-204-author-cleanup.patch
>
>
> Per MAHOUT-165, we need to refactor the matrix package structures a bit to be 
> more coherent and clean.  For instance, there are two levels of matrix 
> packages now, so those should be rectified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.