[
https://issues.apache.org/jira/browse/MAHOUT-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792847#action_12792847
]
Drew Farris commented on MAHOUT-226:
------------------------------------
Patch applied cleanly.
When building, mvn complained that the source level on the compiler was not set
properly for the collections-codegen-plugin project, but adding a
maven-complier-plugin configuration stanza to the pom resolved this problem.
The parent pom (maven/pom.xml) should be fixed to add this so that the children
are not required to, but I suspect that should be handled as a separate issue,
so perhaps for now it could be added to the collections-codegen-plugin pom?
Must the template and generated classes retain the cern copyright message?
Would we want to generate things {type}Object{class} and Object{type}{class}
(e.g: LongObjectProcedure or ObjectIntProcedure) using this approach as well?
I really like the plugin approach. I wonder if we should name it something more
generic so that it would be a natural location other mahout-specific maven
goals could be realized in that submodule, e.g: mahout-maven-plugin with a goal
of mahout:generate-collections-sources, for example to build the mahout .job
file - but perhaps that's worth a separate discussion for the dev list, so I
would also say this is ok the way it is.
> Velocity-based code generation support to support more primitive type
> collections
> ---------------------------------------------------------------------------------
>
> Key: MAHOUT-226
> URL: https://issues.apache.org/jira/browse/MAHOUT-226
> Project: Mahout
> Issue Type: Task
> Components: Matrix
> Reporter: Benson Margulies
> Attachments: codegen.patch
>
>
> We want the complete set of hash maps on the primitive types. The code can be
> generated. So here's a code generator to do it, and, to show it off, the
> TypeTypeFunction.java family set up to be generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
