No.. Thats fixed. StringReader change was to prevent encoding errors. This patch works just fine. Infact I will post some numbers up on running it against wikipedia tonight
Robin On Tue, Jan 12, 2010 at 7:25 PM, Sean Owen <[email protected]> wrote: > Sorry but isn't that the very problem you are trying to solve on this > thread? why do you want to commit this if it has this big memory > problem. > > On Tue, Jan 12, 2010 at 12:49 PM, Robin Anil <[email protected]> wrote: > > > https://issues.apache.org/jira/secure/attachment/12429906/DictionaryVectorizer.patch > > > > Havent changed the StringReader portion. rest are ok to review > > > > > > On Tue, Jan 12, 2010 at 4:47 PM, Sean Owen <[email protected]> wrote: > > > >> > >> > https://issues.apache.org/jira/secure/attachment/12429846/DictionaryVectorizer.patch > >> > >> This one? still seems to have the issues described in this thread. > >> Where's the latest one? > >> > >> On Tue, Jan 12, 2010 at 9:08 AM, Robin Anil <[email protected]> > wrote: > >> > Hi Sean, Could you take a look at the Patch and comment. > >> > > >> > Robin > >> > > >
