Benson, there are many places where FindBugs and PMD plugin scream of issues. I saw some 5K issues on math+collections alone in PMD. I helped remove some from the set and map templates. Do check it out
Robin On Mon, Feb 8, 2010 at 9:10 AM, Sean <sro...@gmail.com> wrote: > Hum, I guess that's the final answer if it's from javac. Though in > theory there's not a reason this must be so. I forget if we already > went through this. > > But what I don't get is why it's stopped working. I also saw this > problem today. The annotations and pom have been that way for some > time. Did something become an interface? > > No I don't think the whole project should use 1.5 -- we can't in fact > since Hadoop uses 1.6. > > Worst case we remove those annotations but want to figure out what > changed first. > > On Mon, Feb 8, 2010 at 3:03 AM, Benson Margulies <bimargul...@gmail.com> > wrote: > > Oh, well, maven doesn't think this possible: > > > > [INFO] Compilation failure > > Failure executing javac, but could not parse the error: > > javac: source release 1.6 requires target release 1.6 > > > > > > > > On Sun, Feb 7, 2010 at 10:00 PM, Benson Margulies <bimargul...@gmail.com> > wrote: > >> OK, that's not what we have in the POM: > >> > >> <configuration> > >> <source>1.5</source> > >> <target>1.5</target> > >> </configuration> > >> > >> I guess I'll make a patch for that. > >> > >> On Sun, Feb 7, 2010 at 9:53 PM, Sean <sro...@gmail.com> wrote: > >>> Yes, runtime compatibility, not compile time. Compiler should treat > >>> the code as 1.6 and output 1.5 bytecode. > >>> > >>> On Mon, Feb 8, 2010 at 2:51 AM, Benson Margulies < > bimargul...@gmail.com> wrote: > >>>> I thought we were trying for 1.5 compat after all. If we are, someone > >>>> (me) should fix all of these. If not, we should change the compiler > >>>> plugin in the POM to say 1.6. > >>>> > >>>> Eclipse treats this as a fatal compilation error if the setting is > '1.5.'. > >>>> > >>> > >> > > >
