Yeah I thought so. We are just before a release. And very few issues are
left with patches submitted. Thats why I wanted that list of files so that I
can commit the rest



On Sat, Feb 13, 2010 at 10:21 PM, Grant Ingersoll <gsing...@apache.org>wrote:

> It's fine to go with this one, but in general massive reformatting is not
> necessarily a good thing b/c it likely breaks a whole bunch of perfectly
> valid patches in JIRA, thus making more work for you later, not less.
>  Instead, I think the way to handle this stuff is to make sure that, when
> ready to commit, all of those files that have been touched are properly
> formatted.  This will still likely break some patches, but not as many.
>
> On Feb 13, 2010, at 9:55 AM, Robin Anil wrote:
>
> > I just did a mass code cleanup.
> >
> > Mainly comprising of
> > -Extra blank line removal
> > -Organize Imports across all packages.
> > -Making local variables final
> >
> > No reordering of methods or code style changes are applied.
> >
> > Any objections or any particular class to withhold from committing.
> >
> > Robin
>
>
>

Reply via email to