I think an initial build is needed. The files should not be checked in -- Eclipse requires one-per-project and the magic dust is pushing copies from a central location. Ignores are fine. I have blankets for those files in my personal settings so I didn't spot the issue.
I don't know the parentage of the PMD file that was checked in. It might even have come from me a long time ago. I do hate warnings, so my view, personally, is that we either keep+fix or remove. Is anyone else interested in wrestling with PMD. On Mon, Mar 22, 2010 at 9:41 PM, Drew Farris <drew.far...@gmail.com> wrote: > I checked out a clean trunk and managed to get as far as step 6 > without problems. 6 failed trying to pull the collections-codegen > plugin 0.4-SNAPSHOT from a repo. I'm not sure why the reactor is not > picking it up. Nevertheless, I was able to get past this by running a > separate mvn clean install to push the plugin to my local repo. > > When all is said and done, I get a bunch of errors from > mahout-collections complaining about the @Overrides. Switching > compliance to 1.6 of course eliminates these. > > The .checkstyle, .pmd and .ruleset files under each project cause svn > to show changes. We should set svn:ignore on these -- or should they > be checked in? > > Without getting too specific it strikes me that some of the stuff that > PMD is complaning about should be downgraded from 'Error high' or > 'Error' to some level of warning. For example it appears that all of > the modules have errors of some level based on the existing (default?) > settings. > > FWIW, here's my environment: > mvn --version > Apache Maven 2.2.1 (r801777; 2009-08-06 15:16:01-0400) > Java version: 1.6.0_16 > Java home: /u01/opt/jdk1.6.0_16/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.28-18-server" arch: "i386" Family: "unix" > > On Mon, Mar 22, 2010 at 9:35 AM, Benson Margulies <bimargul...@gmail.com> > wrote: >> I need a brave eclipse user to try out the following, and then I have >> some questions for others. >> >> 1) Remove all .project and .classpath files from your tree. >> 2) cd to 'eclipse'. >> 3) Pick a new pathname for an eclipse workspace (call it WORKSPACE) in >> the following. >> 4) mvn -Psetup-eclipse-workspace -Declipse.workspace.dir=WORKSPACE >> >> This much will create WORKSPACE, copy some files into it, and set some >> global options. >> >> 5) cd .. (to the mahout top) >> 6) mvn -Psetup.eclipse -Declipse.workspace=WORKSPACE >> >> Now there will be .project and .classpath files. >> >> 7) start eclipse, select WORKSPACE >> 8) import projects from the mahout toplevel >> >> If all goes well, you will be presented with a lot of PMD complaints. >> I turned on PMD as part of the show, and it seems that we have a >> supply of PMD non-compliance. What do people think about the PMD rules >> we have checked in? Do we want to conform to them? >> >
