------------------------------------------------------------
revno: 1438
fixes bug: https://launchpad.net/bugs/1257112
committer: Mark Sapiro <m...@msapiro.net>
branch nick: 2.1
timestamp: Mon 2013-12-02 15:26:58 -0800
message:
  - Fixed a bug which caused some authentication cookies to expire too soon
    if AUTHENTICATION_COOKIE_LIFETIME is non-zero.
modified:
  Mailman/SecurityManager.py
  NEWS


--
lp:mailman/2.1
https://code.launchpad.net/~mailman-coders/mailman/2.1

Your team Mailman Checkins is subscribed to branch lp:mailman/2.1.
To unsubscribe from this branch go to 
https://code.launchpad.net/~mailman-coders/mailman/2.1/+edit-subscription
=== modified file 'Mailman/SecurityManager.py'
--- Mailman/SecurityManager.py	2011-11-26 19:03:58 +0000
+++ Mailman/SecurityManager.py	2013-12-02 23:26:58 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 1998-2011 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2013 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -319,8 +319,6 @@
                          for u in usernames]:
                 ok = self.__checkone(c, authcontext, user)
                 if ok:
-                    # Refresh the cookie
-                    print self.MakeCookie(authcontext, user)
                     return True
             return False
         else:
@@ -362,6 +360,8 @@
         if mac <> received_mac:
             return False
         # Authenticated!
+        # Refresh the cookie
+        print self.MakeCookie(authcontext, user)
         return True
 
 

=== modified file 'NEWS'
--- NEWS	2013-12-01 21:22:52 +0000
+++ NEWS	2013-12-02 23:26:58 +0000
@@ -1,6 +1,6 @@
 -*- coding: iso-8859-1 -*-
 Mailman - The GNU Mailing List Management System
-Copyright (C) 1998-2011 by the Free Software Foundation, Inc.
+Copyright (C) 1998-2013 by the Free Software Foundation, Inc.
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
 
 Here is a history of user visible changes to Mailman.
@@ -8,6 +8,9 @@
 2.1.18 (xx-xxx-xxxx)
 
   Bug Fixes and other patches
+
+    - Fixed a bug which caused some authentication cookies to expire too soon
+      if AUTHENTICATION_COOKIE_LIFETIME is non-zero.  (LP: #1257112)
  
     - Fixed a possible TypeError in bin/sync_members introduced in 2.1.17.
       (LP: #1243343)

_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org

Reply via email to