------------------------------------------------------------
revno: 1548
fixes bug: https://launchpad.net/bugs/1426829
committer: Mark Sapiro <m...@msapiro.net>
branch nick: 2.1
timestamp: Sun 2015-03-01 08:35:02 -0800
message:
  Fixed a bug in CommandRunner that could process the second word of a
  body line as a command word and a case sensitivity in commands in
  Subject: with an Re: prefix.
modified:
  Mailman/Queue/CommandRunner.py
  NEWS


--
lp:mailman/2.1
https://code.launchpad.net/~mailman-coders/mailman/2.1

Your team Mailman Checkins is subscribed to branch lp:mailman/2.1.
To unsubscribe from this branch go to 
https://code.launchpad.net/~mailman-coders/mailman/2.1/+edit-subscription
=== modified file 'Mailman/Queue/CommandRunner.py'
--- Mailman/Queue/CommandRunner.py	2015-03-01 07:05:56 +0000
+++ Mailman/Queue/CommandRunner.py	2015-03-01 16:35:02 +0000
@@ -146,18 +146,21 @@
             #
             # If that still didn't work it isn't enough to stop processing.
             # BAW: should we include a message that the Subject: was ignored?
+            #
+            # But first, be sure we're looking at the Subject: and not past
+            # it already.
+            if self.lineno != 0:
+                return BADCMD
             if self.subjcmdretried < 1:
                 self.subjcmdretried += 1
                 if re.search('^.*:.+', cmd):
-                    return self.do_command(re.sub('.*:', '', cmd), args)
+                    cmd = re.sub('.*:', '', cmd).lower()
+                    return self.do_command(cmd, args)
             if self.subjcmdretried < 2 and args:
                 self.subjcmdretried += 1
-                cmd = args.pop(0)
+                cmd = args.pop(0).lower()
                 return self.do_command(cmd, args)
-            if self.lineno <> 0:
-                return BADCMD
-            else:
-                return BADSUBJ
+            return BADSUBJ
         if handler.process(self, args):
             return STOP
         else:

=== modified file 'NEWS'
--- NEWS	2015-03-01 07:05:56 +0000
+++ NEWS	2015-03-01 16:35:02 +0000
@@ -9,6 +9,10 @@
 
   Bug fixes and other patches
 
+    - Fixed a bug in CommandRunner that could process the second word of a
+      body line as a command word and a case sensitivity in commands in
+      Subject: with an Re: prefix.  (LP: #1426829)
+
     - Fixed a bug in CommandRunner that threw an uncaught KeyError if
       the input to the list-request address contained a command word
       terminated by a period.  (LP: #1426825)

_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org

Reply via email to