Barry Warsaw pushed to branch master at mailman / Mailman
Commits:
c265a58e by Barry Warsaw at 2015-08-18T21:16:59Z
Turn off tying the -E test suite option to debugging the database logger.
SQLAlchemy is generally pretty chatty and usually not necessary to debug.
Set use_poll=True in asyncore.loop() which improves Python 3.5 compatibility.
We were getting OSErrors in stop() when using select under Python 3.5.
- - - - -
2 changed files:
- src/mailman/runners/lmtp.py
- src/mailman/testing/layers.py
Changes:
=====================================
src/mailman/runners/lmtp.py
=====================================
--- a/src/mailman/runners/lmtp.py
+++ b/src/mailman/runners/lmtp.py
@@ -255,7 +255,7 @@ class LMTPRunner(Runner, smtpd.SMTPServer):
def run(self):
"""See `IRunner`."""
- asyncore.loop()
+ asyncore.loop(use_poll=True)
def stop(self):
"""See `IRunner`."""
=====================================
src/mailman/testing/layers.py
=====================================
--- a/src/mailman/testing/layers.py
+++ b/src/mailman/testing/layers.py
@@ -158,8 +158,11 @@ class ConfigLayer(MockAndMonkeyLayer):
get_handler(sub_name).reopen(path)
log.setLevel(logging.DEBUG)
# If stderr debugging is enabled, make sure subprocesses are also
- # more verbose.
- if cls.stderr:
+ # more verbose. In general though, we still don't want SQLAlchemy
+ # debugging because it's just too verbose. Unfortunately, if you
+ # do want that level of debugging you currently have to manually
+ # modify this conditional.
+ if cls.stderr and sub_name != 'database':
test_config += expand(dedent("""
[logging.$name]
propagate: yes
View it on GitLab:
https://gitlab.com/mailman/mailman/commit/c265a58eea8bb7abbdaa4cdbc0f25cafb1d78626
_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe:
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
