------------------------------------------------------------
revno: 1652
fixes bug: https://launchpad.net/bugs/1582856
committer: Mark Sapiro <m...@msapiro.net>
branch nick: 2.1
timestamp: Tue 2016-05-17 13:54:43 -0700
message:
Improved logging of banned subscription and address change attempts.
modified:
Mailman/MailList.py
NEWS
--
lp:mailman/2.1
https://code.launchpad.net/~mailman-coders/mailman/2.1
Your team Mailman Checkins is subscribed to branch lp:mailman/2.1.
To unsubscribe from this branch go to
https://code.launchpad.net/~mailman-coders/mailman/2.1/+edit-subscription
=== modified file 'Mailman/MailList.py'
--- Mailman/MailList.py 2016-02-05 05:22:38 +0000
+++ Mailman/MailList.py 2016-05-17 20:54:43 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 1998-2015 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2016 by the Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
@@ -809,6 +809,8 @@
# check for banned address
pattern = self.GetBannedPattern(invitee)
if pattern:
+ syslog('vette', '%s banned invitation: %s (matched: %s)',
+ self.real_name, invitee, pattern)
raise Errors.MembershipIsBanned, pattern
# Hack alert! Squirrel away a flag that only invitations have, so
# that we can do something slightly different when an invitation
@@ -1011,6 +1013,12 @@
# and confirmations.
pattern = self.GetBannedPattern(email)
if pattern:
+ if whence:
+ source = ' from %s' % whence
+ else:
+ source = ''
+ syslog('vette', '%s banned subscription: %s%s (matched: %s)',
+ self.real_name, email, source, pattern)
raise Errors.MembershipIsBanned, pattern
# Do the actual addition
self.addNewMember(email, realname=name, digest=digest,
@@ -1175,6 +1183,9 @@
# exception.
pattern = self.GetBannedPattern(newaddr)
if pattern:
+ syslog('vette',
+ '%s banned address change: %s -> %s (matched: %s)',
+ self.real_name, oldaddr, newaddr, pattern)
raise Errors.MembershipIsBanned, pattern
# It's possible they were a member of this list, but choose to change
# their membership globally. In that case, we simply remove the old
=== modified file 'NEWS'
--- NEWS 2016-05-17 19:33:14 +0000
+++ NEWS 2016-05-17 20:54:43 +0000
@@ -25,6 +25,9 @@
Bug fixes and other patches
+ - Improved logging of banned subscription and address change attempts.
+ (LP: #1582856)
+
- In rare circumstances a list can be removed while the admin or listinfo
CGI or bin/list_lists is running causing an uncaught MMUnknownListError
to be thrown. The exception is now caught and handled. (LP: #1582532)
_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe:
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
