Barry Warsaw pushed to branch master at mailman / Mailman
Commits: 63de6706 by Abhilash Raj at 2016-08-29T12:06:02-04:00 Intermediate Commit - - - - - 5db5eb34 by Barry Warsaw at 2016-08-29T12:06:02-04:00 Checkpointing. - - - - - 9a1f3936 by Barry Warsaw at 2016-08-30T21:02:06-04:00 Checkpointing - - - - - 88f34990 by Abhilash Raj at 2016-09-01T06:55:09-04:00 Intermediate Commit - - - - - 975b5e0a by Barry Warsaw at 2016-09-01T06:55:09-04:00 Checkpointing. - - - - - 84c0f953 by Barry Warsaw at 2016-09-01T06:55:09-04:00 Checkpointing - - - - - 1cf46c88 by Barry Warsaw at 2016-09-01T06:55:14-04:00 Merge branch 'issue213' of gitlab.com:warsaw/mailman into issue213 - - - - - 9f7fa58e by Barry Warsaw at 2016-09-01T07:39:10-04:00 IWorkflowManager -> ISubscriptionManager - - - - - 5bd245f9 by Barry Warsaw at 2016-09-02T09:56:44-04:00 Remove workflowmanager.py - - - - - 54ae6bb8 by Barry Warsaw at 2016-09-02T10:29:52-04:00 Fix migration. - - - - - 447b9bd6 by Barry Warsaw at 2016-09-08T19:49:00+12:00 Fix many failures. Also, document more APIs. - - - - - 655e04a6 by Barry Warsaw at 2016-09-08T21:14:48+12:00 A few more changes. - - - - - 45c8aa0d by Barry Warsaw at 2016-09-09T18:21:58+12:00 More test fixes. - - - - - 1db20c85 by Barry Warsaw at 2016-09-11T07:15:12+12:00 Collapse two doctests into one. Also, fix the return value of .unregister(), and make the tests pass. - - - - - e18e7ac3 by Barry Warsaw at 2016-09-11T19:51:21+12:00 Fix more tests. - - - - - 74c7d6d1 by Barry Warsaw at 2016-09-13T19:43:34+12:00 Split registration (subscription) and unsubscription: * events * notices * handlers Also, be sure to do only one `leave` command per email. - - - - - 47fa9b07 by Barry Warsaw at 2016-09-13T19:54:10+12:00 Fix test. - - - - - 172d9471 by Barry Warsaw at 2016-09-16T08:51:01+12:00 Another test fix. - - - - - 511c8691 by Barry Warsaw at 2016-09-16T22:24:19+12:00 Another fix. - - - - - 3ba58c6f by Barry Warsaw at 2016-09-16T22:35:10+12:00 Another fix. - - - - - 76a8fe78 by Barry Warsaw at 2016-09-19T07:22:57-04:00 Minor changes. - - - - - f2a532ef by Barry Warsaw at 2016-10-09T13:40:13-04:00 Merge branch 'master' into issue213 - - - - - 61a13bbb by Barry Warsaw at 2016-10-16T13:13:08-04:00 Merge branch 'master' into issue213. - - - - - b530d7d6 by Barry Warsaw at 2016-10-16T13:18:04-04:00 flake8 fixes. - - - - - 9607560b by Barry Warsaw at 2016-10-16T13:41:21-04:00 Fix one migration failure. - - - - - 90a69619 by Barry Warsaw at 2016-10-16T14:24:12-04:00 Another test repair. - - - - - 82a913bb by Barry Warsaw at 2016-10-16T16:12:29-04:00 More test repair. - - - - - d45af03c by Barry Warsaw at 2016-10-17T09:13:32-04:00 Simplify the implementation. This merges the SubscriptionManager and UnsubscriptionManager into a single SubscriptionManager implementation that handles both register() and unregister(). This allows us to use direct class-based adaptation instead of the more clunky getAdapter() API. We can also eliminate the funky _get_workflow() implementation detail. This has a couple of side-effects. .confirm() must lookup the token in the pendings database and pull out the pending type, dispatching to the proper class depending on the type, or raising a LookupError if the token is None or there is no pendable associated with the given token. This feels like an acceptable trade-off. However, this *also* means that IWorkflowStateManager must lose its 'name' argument in its methods. That's because we won't actually know the name until its too late. Honestly, the name wasn't providing much value anyway (it was always the subclass's name), so losing that seems fine too. The complication here is that the name was a primary key in the 'workflowstate' table, so we need to add its removal in the database migration. - - - - - 763025ce by Barry Warsaw at 2016-10-18T21:03:59-04:00 Refactor. - - - - - 946aa821 by Barry Warsaw at 2016-10-18T21:10:30-04:00 NEWS. - - - - - c8f3294e by Barry Warsaw at 2016-10-21T00:02:17-04:00 99% test coverage. Also: * Ignore coverage in the testing submodule. * Remove some unreachable code. * Spelling. * Fix a bug in run_thru(). - - - - - f036d465 by Barry Warsaw at 2016-10-21T11:06:46-04:00 100% diffcov - - - - - 30 changed files: - coverage.ini - src/mailman/app/docs/moderator.rst - src/mailman/app/events.py - − src/mailman/app/registrar.py - src/mailman/app/subscriptions.py - src/mailman/app/tests/test_moderation.py - src/mailman/app/tests/test_subscriptions.py - + src/mailman/app/tests/test_unsubscriptions.py - src/mailman/app/tests/test_registrar.py → src/mailman/app/tests/test_workflowmanager.py - src/mailman/app/workflow.py - src/mailman/commands/docs/membership.rst - src/mailman/commands/eml_confirm.py - src/mailman/commands/eml_membership.py - src/mailman/commands/tests/test_confirm.py - + src/mailman/commands/tests/test_membership.py - src/mailman/config/configure.zcml - src/mailman/database/alembic/versions/16c2b25c7b_list_subscription_policy.py - + src/mailman/database/alembic/versions/448a93984c35_unsubscription_workflow.py - src/mailman/database/alembic/versions/fa0d96e28631_template_manager.py - src/mailman/database/tests/test_migrations.py - src/mailman/docs/NEWS.rst - src/mailman/interfaces/mailinglist.py - − src/mailman/interfaces/registrar.py - src/mailman/interfaces/subscriptions.py - src/mailman/interfaces/template.py - src/mailman/interfaces/workflow.py - − src/mailman/model/docs/registration.rst - src/mailman/model/docs/subscriptions.rst - src/mailman/model/mailinglist.py - src/mailman/model/pending.py The diff was not included because it is too large. View it on GitLab: https://gitlab.com/mailman/mailman/compare/f0fcc8b74472c8361ac58b2c4a17b6dd4d1f109d...f036d465725204a294a6e2f582750aaab875eb18
_______________________________________________ Mailman-checkins mailing list Mailman-checkins@python.org Unsubscribe: https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
