Barry Warsaw pushed to branch click-cli at mailman / Mailman Core

Commits:
4da15e6b by Barry Warsaw at 2017-07-20T10:07:49-05:00
Suppress an annoying Alembic/SQLite warning.

- - - - -
fbfe4a9d by Barry Warsaw at 2017-07-20T10:19:14-05:00
100% diffcov.

* Make generic the Python 3 paths in coverage.ini
* Add some pragma: nocovers to runner.py to avoid blocking diffcov tests

- - - - -
7215df53 by Barry Warsaw at 2017-07-20T10:26:55-05:00
One last NEWS update!

- - - - -


4 changed files:

- coverage.ini
- src/mailman/core/runner.py
- src/mailman/database/tests/test_migrations.py
- src/mailman/docs/NEWS.rst


Changes:

=====================================
coverage.ini
=====================================
--- a/coverage.ini
+++ b/coverage.ini
@@ -4,8 +4,8 @@ parallel = true
 omit =
      setup*
      */showme.py
-    .tox/*/lib/python3.5/site-packages/*
-    .tox/*/lib/python3.5/site-packages/*
+    .tox/*/lib/python3.*/site-packages/*
+    .tox/*/lib/python3.*/site-packages/*
     */test_*.py
     /tmp/*
     /private/var/folders/*
@@ -21,4 +21,4 @@ exclude_lines =
 [paths]
 source =
     mailman
-    .tox/coverage/lib/python*/site-packages/mailman
+    .tox/*/lib/python3.*/site-packages/mailman


=====================================
src/mailman/core/runner.py
=====================================
--- a/src/mailman/core/runner.py
+++ b/src/mailman/core/runner.py
@@ -86,7 +86,7 @@ class Runner:
     def __repr__(self):
         return '<{} at {:#x}>'.format(self.__class__.__name__, id(self))
 
-    def signal_handler(self, signum, frame):
+    def signal_handler(self, signum, frame):        # pragma: nocover
         signame = {
             signal.SIGTERM: 'SIGTERM',
             signal.SIGINT: 'SIGINT',


=====================================
src/mailman/database/tests/test_migrations.py
=====================================
--- a/src/mailman/database/tests/test_migrations.py
+++ b/src/mailman/database/tests/test_migrations.py
@@ -35,6 +35,7 @@ from mailman.interfaces.member import MemberRole
 from mailman.interfaces.template import ITemplateManager
 from mailman.interfaces.usermanager import IUserManager
 from mailman.testing.layers import ConfigLayer
+from warnings import catch_warnings, simplefilter
 from zope.component import getUtility
 
 
@@ -63,11 +64,21 @@ class TestMigrations(unittest.TestCase):
     def test_all_migrations(self):
         script_dir = alembic.script.ScriptDirectory.from_config(alembic_cfg)
         revisions = [sc.revision for sc in script_dir.walk_revisions()]
-        for revision in revisions:
-            alembic.command.downgrade(alembic_cfg, revision)
-        revisions.reverse()
-        for revision in revisions:
-            alembic.command.upgrade(alembic_cfg, revision)
+        with catch_warnings():
+            simplefilter('ignore', UserWarning)
+            # Alembic/SQLite does not like something about these migrations.
+            # They're more or less inconsequential in practice (since users
+            # will rarely if ever downgrade their database), but it does
+            # clutter up the test output, so just suppress the warning.
+            #
+            # E.g.
+            # alembic/util/messaging.py:69: UserWarning:
+            # Skipping unsupported ALTER for creation of implicit constraint
+            for revision in revisions:
+                alembic.command.downgrade(alembic_cfg, revision)
+            revisions.reverse()
+            for revision in revisions:
+                alembic.command.upgrade(alembic_cfg, revision)
 
     def test_42756496720_header_matches(self):
         test_header_matches = [


=====================================
src/mailman/docs/NEWS.rst
=====================================
--- a/src/mailman/docs/NEWS.rst
+++ b/src/mailman/docs/NEWS.rst
@@ -27,7 +27,8 @@ Command line
 * Adopt the ``click`` package for command line parsing.  This makes the
   command line more consistent and pluggable.  Also, many CLIs that accepted a
   "fqdn list name" (i.e. the posting address of a mailing list), now also
-  accept a ``List-ID``.  (Closes #346)
+  accept a ``List-ID``.  Every attempt has been made to keep the CLI backward
+  compatible, but there may be subtle differences.  (Closes #346)
 * Fix ``mailman withlist`` command parsing.  (Closes #319)
 
 Interfaces
@@ -40,6 +41,7 @@ Interfaces
 Other
 -----
 * Drop support for Python 3.4.  (Closes #373)
+* Bump minimum requirements for aiosmtpd (>= 1.1) and flufl.lock (>= 3.1).
 
 
 3.1.0 -- "Between The Wheels"



View it on GitLab: 
https://gitlab.com/mailman/mailman/compare/d55ea8615406d13cb1e6a1508b17a98b21797a49...7215df535b109cbd5b56b64d3b4c62ed5235ec7f

---
View it on GitLab: 
https://gitlab.com/mailman/mailman/compare/d55ea8615406d13cb1e6a1508b17a98b21797a49...7215df535b109cbd5b56b64d3b4c62ed5235ec7f
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org

Reply via email to