Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core


Commits:
1fa08ce8 by Mark Sapiro at 2023-02-09T01:21:22+00:00
Don't log StopIteration in workflow.

Fixes #1059

* Don't log StopIteration in workflow.

- - - - -
74684ddf by Mark Sapiro at 2023-02-09T01:21:22+00:00
Merge branch 'si' into 'master'

Don't log StopIteration in workflow.

Closes #1059

See merge request mailman/mailman!1100

Merged-by: Mark Sapiro <m...@msapiro.net>

Reviewed-by: 
- - - - -


2 changed files:

- src/mailman/app/workflow.py
- src/mailman/docs/NEWS.rst


Changes:

=====================================
src/mailman/app/workflow.py
=====================================
@@ -67,7 +67,8 @@ class Workflow:
         try:
             name, step = self._pop()
             return step()
-        except IndexError:
+        except (IndexError, StopIteration):
+            # Catch StopIteration so it's not logged. See #1059.
             raise StopIteration
         except:                                     # noqa: E722
             log.exception('deque: {}'.format(COMMASPACE.join(self._next)))


=====================================
src/mailman/docs/NEWS.rst
=====================================
@@ -34,6 +34,8 @@ Bugs fixed
   ``use_ipython: yes``.  (Closes #1062)
 * Bogus Message-ID headers that have been observed in the wild are now fixed.
   (Closes #1065)
+* Raising StopIteration in a workflow process no longer creates a mailman.error
+  log entry.  (Closes #1059)
 
 .. _news-3.3.8:
 



View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/52046f3afddd9b0405b1dfb084933c98c0d2ebb2...74684ddfbc6a365c7f04e72cc849d13992ccc446

-- 
View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/52046f3afddd9b0405b1dfb084933c98c0d2ebb2...74684ddfbc6a365c7f04e72cc849d13992ccc446
You're receiving this email because of your account on gitlab.com.


_______________________________________________
Mailman-checkins mailing list -- mailman-checkins@python.org
To unsubscribe send an email to mailman-checkins-le...@python.org
https://mail.python.org/mailman3/lists/mailman-checkins.python.org/
Member address: arch...@jab.org

Reply via email to