Pranjal Yadav has proposed merging lp:~godricglow/postorius/bug_1308219_fix 
into lp:postorius.

Requested reviews:
  Mailman Coders (mailman-coders)

For more details, see:
https://code.launchpad.net/~godricglow/postorius/bug_1308219_fix/+merge/248046

Fixed 1308219 by avoiding else loop back and a default new.form() for both 
moderator and owner after submit click.
-- 
Your team Mailman Coders is requested to review the proposed merge of 
lp:~godricglow/postorius/bug_1308219_fix into lp:postorius.
=== modified file 'src/postorius/views/list.py'
--- src/postorius/views/list.py	2015-01-19 15:03:09 +0000
+++ src/postorius/views/list.py	2015-01-29 19:57:44 +0000
@@ -66,8 +66,6 @@
                                    % request.POST['owner_email']))
                 except HTTPError as e:
                     messages.error(request, _(e.msg))
-        else:
-            owner_form = NewOwnerForm()
         if 'moderator_email' in request.POST:
             moderator_form = NewModeratorForm(request.POST)
             if moderator_form.is_valid():
@@ -79,8 +77,8 @@
                                    % request.POST['moderator_email']))
                 except HTTPError as e:
                     messages.error(request, _(e.msg))
-        else:
-            moderator_form = NewModeratorForm()
+        owner_form = NewOwnerForm()
+        moderator_form = NewModeratorForm()
         return render_to_response('postorius/lists/members.html',
                                   {'list': self.mailing_list,
                                    'owner_form': owner_form,

_______________________________________________
Mailman-coders mailing list
Mailman-coders@python.org
https://mail.python.org/mailman/listinfo/mailman-coders

Reply via email to