Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/mailman/Fixed_Bug into
lp:mailman.
Requested reviews:
Mailman Coders (mailman-coders)
For more details, see:
https://code.launchpad.net/~bhavesh-goyal093/mailman/Fixed_Bug/+merge/251886
Fixed Bug # #1425359 which caused postorius to show 500 error code instead of
409 when same but case sensitive email addresses are entered into subscription
list.
Earlier : 500 error code when email addresses such as x...@gmail.com and
x...@gmail.com are entered which are same
Now: 409 error code in both cases since they are same
--
Your team Mailman Coders is requested to review the proposed merge of
lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman.
=== modified file 'src/mailman/app/membership.py'
--- src/mailman/app/membership.py 2015-01-05 01:22:39 +0000
+++ src/mailman/app/membership.py 2015-03-05 09:31:39 +0000
@@ -98,10 +98,10 @@
else:
# The user exists and is linked to the address.
for address in user.addresses:
- if address.email == email:
+ if address.email.split('@')[0] + address.email.split('@')[1].lower() == email.split('@')[0] + email.split('@')[1].lower():
break
- else:
- raise AssertionError(
+ else:
+ raise AssertionError(
'User should have had linked address: {0}'.format(address))
# Create the member and set the appropriate preferences.
member = mlist.subscribe(address, role)
_______________________________________________
Mailman-coders mailing list
Mailman-coders@python.org
https://mail.python.org/mailman/listinfo/mailman-coders
