Bhavesh Goyal has proposed merging
lp:~bhavesh-goyal093/postorius/postorius-fix-ui into lp:postorius.
Requested reviews:
Mailman Coders (mailman-coders)
For more details, see:
https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-fix-ui/+merge/252202
Subscription Based Preferences page in postorius had wrongly aligned radio
buttons which mislead the user to selecting incorrect choices and affected UI
of postorius too.
Now the radio buttons are correctly aligned vertically rather than in an
unordered fashion.
Also, the mailing list settings forms are now cleaner in the sense that earlier
the width of class element 'well' was uneven which affected the overall look of
postorius, now all forms are of same width and ui looks better in overall
--
Your team Mailman Coders is requested to review the proposed merge of
lp:~bhavesh-goyal093/postorius/postorius-fix-ui into lp:postorius.
=== modified file 'src/postorius/static/postorius/css/style.css'
--- src/postorius/static/postorius/css/style.css 2015-02-06 15:50:56 +0000
+++ src/postorius/static/postorius/css/style.css 2015-03-07 11:54:10 +0000
@@ -212,6 +212,9 @@
}
/* auto-generated forms made a bit cleaner */
+.well {
+ width: 100%;
+}
.well label {
display: inline;
}
=== modified file 'src/postorius/templates/postorius/lists/memberoptions.html'
--- src/postorius/templates/postorius/lists/memberoptions.html 2015-01-09 14:40:06 +0000
+++ src/postorius/templates/postorius/lists/memberoptions.html 2015-03-07 11:54:10 +0000
@@ -4,7 +4,7 @@
{% load nav_helpers %}
{% block main %}
- {% list_nav '' '' %}
+ {% list_nav '' ' ' %}
{% if not user.is_superuser or not user.is_list_owner %}
<div class="mm_subHeader" >
=== modified file 'src/postorius/templates/postorius/user_subscription_preferences.html'
--- src/postorius/templates/postorius/user_subscription_preferences.html 2015-01-09 16:07:56 +0000
+++ src/postorius/templates/postorius/user_subscription_preferences.html 2015-03-07 11:54:10 +0000
@@ -35,14 +35,34 @@
<tr class = "{% cycle row1,row2 %}" >
{% for form,subscription in zipped_data %}
<td style="width:10%">{{subscription.list_id}}</td>
- <td style="width:14%">{{form.delivery_status}}</td>
+ <td style="width:14%"><table>
+ {% for field in form.delivery_status %}
+ <tr><td>{{ field }}</td></tr>
+ {% endfor %}</table>
+ </td>
<td style="width:20%">{{form.delivery_mode}}</td>
- <td style="width:14%">{{form.receive_own_postings}}</td>
- <td style="width:14%">{{form.acknowledge_posts}}</td>
- <td style="width:14%">{{form.hide_address}}</td>
- <td style="width:14%">{{form.receive_list_copy}}</td>
- </tr>
+ <td style="width:14%"><table>
+ {% for field in form.receive_own_postings %}
+ <tr><td>{{ field }}</td></tr>
+ {% endfor %}</table>
+ </td>
+ <td style="width:14%"><table>
+ {% for field in form.acknowledge_posts %}
+ <tr><td>{{ field }}</td></tr>
+ {% endfor %}</table>
+ </td>
+ <td style="width:14%"><table>
+ {% for field in form.hide_address %}
+ <tr><td>{{ field }}</td></tr>
+ {% endfor %}</table>
+ </td>
+ <td style="width:14%"><table>
+ {% for field in form.receive_list_copy %}
+ <tr><td>{{ field }}</td></tr>
+ {% endfor %}</table>
+ </td>
{% endfor %}
+ </tr>
</table>
<center><button class="btn btn-success" type="submit"> {% trans "Save" %}</button></center>
</form>
_______________________________________________
Mailman-coders mailing list
Mailman-coders@python.org
https://mail.python.org/mailman/listinfo/mailman-coders
