Pavan Koli has proposed merging lp:~pskoli93/postorius/More_info_Fixes into
lp:postorius.
Requested reviews:
Mailman Coders (mailman-coders)
For more details, see:
https://code.launchpad.net/~pskoli93/postorius/More_info_Fixes/+merge/257923
If go to My settings. There if you click on More info option, it just opens a
new tab. Fix has removed the associated anchor text.
--
Your team Mailman Coders is requested to review the proposed merge of
lp:~pskoli93/postorius/More_info_Fixes into lp:postorius.
=== modified file 'src/postorius/templates/postorius/user_address_preferences.html'
--- src/postorius/templates/postorius/user_address_preferences.html 2015-04-15 00:43:21 +0000
+++ src/postorius/templates/postorius/user_address_preferences.html 2015-04-30 16:41:47 +0000
@@ -36,7 +36,7 @@
<tr>
<td>
<p>{% trans 'Mail Delivery' %}: </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_status.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_status.help_text }}
</span></span>]
</p>
</td>
@@ -47,7 +47,7 @@
<tr>
<td>
<p> {% trans 'Select a Mode of Delivery' %}: </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_mode.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_mode.help_text }}
</span></span>]
</p>
</td>
@@ -58,7 +58,7 @@
<tr>
<td>
<p> {% trans 'Receive your own posts to the list?' %} </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_own_postings.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_own_postings.help_text }}
</span></span>]
</p>
</td>
@@ -69,7 +69,7 @@
<tr>
<td>
<p> {% trans 'Receive acknowledgement mails?' %} </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.acknowledge_posts.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.acknowledge_posts.help_text }}
</span></span>]
</p>
</td>
@@ -80,7 +80,7 @@
<tr>
<td>
<p> {% trans 'Conceal yourself from the subscriber list?' %} </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.hide_address.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.hide_address.help_text }}
</span></span>]
</p>
</td>
@@ -91,7 +91,7 @@
<tr>
<td>
<p> {% trans 'Avoid duplicate copies of messages?' %} </p>
- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_list_copy.help_text }}
+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_list_copy.help_text }}
</span></span>]
</p>
</td>
=== modified file 'src/postorius/templates/postorius/user_mailmansettings.html'
--- src/postorius/templates/postorius/user_mailmansettings.html 2015-04-16 01:56:51 +0000
+++ src/postorius/templates/postorius/user_mailmansettings.html 2015-04-30 16:41:47 +0000
@@ -32,7 +32,7 @@
<td>
<p> {% trans "Mail Delivery" %}: </p>
</p>
- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_status.help_text }}
+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_status.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.delivery_status }} </td>
@@ -41,7 +41,7 @@
<td>
<p> {% trans "Select a Mode of Delivery" %}: </p>
</p>
- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_mode.help_text }}
+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_mode.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.delivery_mode }} </td>
@@ -50,7 +50,7 @@
<td>
<p> {% trans "Receive your own posts to the list?" %} </p>
</p>
- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_own_postings.help_text }}
+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_own_postings.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.receive_own_postings }} </td>
@@ -59,7 +59,7 @@
<td>
<p> {% trans "Receive acknowledgement mails?" %} </p>
</p>
- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.acknowledge_posts.help_text }}
+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.acknowledge_posts.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.acknowledge_posts }} </td>
@@ -68,7 +68,7 @@
<td>
<p>{% trans "Conceal yourself from the subscriber list?" %} </p>
</p>
- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.hide_address.help_text }}
+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.hide_address.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.hide_address }} </td>
@@ -76,7 +76,7 @@
<tr>
<td>
<p>{% trans "Avoid duplicate copies of messages?" %}</p>
- </p> [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_list_copy.help_text }}
+ </p> [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_list_copy.help_text }}
</span></span>] </p>
</td>
<td> {{settingsform.receive_list_copy }} </td>
=== modified file 'src/postorius/templates/postorius/user_subscription_preferences.html'
--- src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-15 00:43:21 +0000
+++ src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-30 16:41:47 +0000
@@ -30,7 +30,7 @@
<tr>
<th> {% trans 'Subscription' %} </th>
{% for field in form.visible_fields %}
- <th>{{field.label}} <p><span class="more_info">[<a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ field.help_text }}
+ <th>{{field.label}} <p><span class="more_info">[{% trans 'More info' %}<span>{{ field.help_text }}
</span>]</span></p></th>
{% endfor %}
</tr >
@@ -49,7 +49,7 @@
</tr>
{% endfor %}
</table>
- <center><button class="btn btn-success" type="submit"> {% trans "Save" %}</button></center>
+ <center><button class="btn btn-success" type="submit"> {% trans "Saves" %}</button></center>
</form>
{% endif %}
{% endblock main %}
_______________________________________________
Mailman-coders mailing list
Mailman-coders@python.org
https://mail.python.org/mailman/listinfo/mailman-coders
