There are a few remaining issues regarding logging in the svn trunk.
1) The ReopenableFileHandler.__init__ method in Mailman/loginit.py
calls
logging.FileHandler.__init__(self, filename, mode, encoding)
This method only allows the instance, filename and mode arguments.
The encoding argument throws a TypeError exception.
2) The 'locks' log is missing from the LOGGERS tuple in loginit.py
3) Mailman/LogFile.py still references Mailman.Logging.StampedLogger
This is tricky if we want to maintain its current ability to be
used outside of Mailman.
I *think* we could change
try:
from Mailman.Logging.StampedLogger import StampedLogger
_logfile = StampedLogger('locks')
to
try:
from Mailman import loginit
_logfile = logging.getLogger('mailman.locks')
_logfile.write = _logfile.info
where the import of loginit is just to see if it throws the
exception. I'm not sure if we ever need to actually call
loginit.initialize()
as in most if not all cases, this has already been done by some
superordinate importer of LogFile.
4) Many of the scripts/* files contain
from Mailman.Logging.Utils import LogStdErr
and
LogStdErr('error', 'name')
I think these can just be deleted as the scripts/driver script
does the Mailman.loginit.initialize()
--
Mark Sapiro <[EMAIL PROTECTED]> The highway is for gamblers,
San Francisco Bay Area, California better use your sense - B. Dylan
_______________________________________________
Mailman-Developers mailing list
[email protected]
http://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives:
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe:
http://mail.python.org/mailman/options/mailman-developers/archive%40jab.org
Security Policy:
http://www.python.org/cgi-bin/faqw-mm.py?req=show&file=faq01.027.htp
