Markus Grabner wrote:
>
>    As requested in http://www.gnu.org/software/mailman/devs.html, I would 
>like to note that I noticed a bug in gate_news (mailman-2.1.11), for which a 
>fix has been proposed a couple of years ago. I applied this fix, and it 
>solved the problem for me, so I suggest that this fix goes into the next 
>mailman release if the developers don't see potential problems with it.
>
>More details are here:
>https://bugs.launchpad.net/mailman/+bug/265941


I suggest the attached patch (gate_news.patch.txt) rather than the one
in the bug report. There could be errors such as a bad nntp_host for a
particular list that will throw socket.error. If we're going to not
allow one list's configuration to abort processing (a good thing I
think), we need to continue on socket.error too.

Thoughts?

-- 
Mark Sapiro <[EMAIL PROTECTED]>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan

=== modified file 'cron/gate_news'
--- cron/gate_news      2005-08-27 01:40:17 +0000
+++ cron/gate_news      2008-09-19 20:58:35 +0000
@@ -1,6 +1,6 @@
 #! @PYTHON@
 #
-# Copyright (C) 1998-2003 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2008 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -206,8 +206,11 @@
         # Open the newsgroup, but let most exceptions percolate up.
         try:
             conn, first, last = open_newsgroup(mlist)
-        except (socket.error, nntplib.NNTPError):
-            break
+        except (socket.error, nntplib.NNTPError), e:
+            syslog('fromusnet',
+                   '%s: couldn't open newsgroup %s: skipping\n%s',
+                   listname, mlist.linked_newsgroup, e)
+            continue
         syslog('fromusenet', '%s: [%d..%d]' % (listname, first, last))
         try:
             try:

_______________________________________________
Mailman-Developers mailing list
[email protected]
http://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: 
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9

Reply via email to