> PEP 8 has a line length limit of 79 characters, so this line needs to be
> wrapped.
> PEP 8 requires a single space both before and after the = sign.
>
Thanks for pointing this out. I will get myself familial with PEP 8.
>
> === modified file 'src/mailman/core/switchboard.py'
> --- src/mailman/core/switchboard.py 2013-01-01 14:05:42 +0000
> +++ src/mailman/core/switchboard.py 2013-01-17 07:44:42 +0000
>> @@ -90,9 +90,10 @@
>> 'Not a power of 2: {0}'.format(numslices))
>> self.name = name
>> self.queue_directory = queue_directory
>> + self.non_queue_runner={'lmtp','rest'}
>
> This should no longer be necessary, right? (I hope it's not! :)
>> # Fast track for no slices
>> self._lower = None
>> self._upper = None
>> @@ -143,11 +144,11 @@
>> data['_parsemsg'] = (protocol == 0)
>> # Write to the pickle file the message object and metadata.
>> with open(tmpfile, 'w') as fp:
>> - fp.write(msgsave)
>> - cPickle.dump(data, fp, protocol)
>> - fp.flush()
>> - os.fsync(fp.fileno())
>> - os.rename(tmpfile, filename)
>> + fp.write(msgsave)
>> + cPickle.dump(data, fp, protocol)
>> + fp.flush()
>> + os.fsync(fp.fileno())
>> + os.rename(tmpfile, filename)
>
> Why were these lines changed? The tabs are not allowed in Mailman code.
>
These lines were changed in my earlier commit, which required certain
fixing. So i re-changed these lines to the original one in my recent
commit to the branch. Hence bazaar was showing all that in the commit
history.
> Be careful about trailing whitespace! You might want to set your editor to
> warn you about these, or display such whitespace.
>
At present i am using jus gedit to do all my coding, which edtor is
best to be used so that i do not run into these problems ?
Thanks for the feedback :)
Cheers,
Sandesh
_______________________________________________
Mailman-Developers mailing list
[email protected]
http://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives:
http://www.mail-archive.com/mailman-developers%40python.org/
Unsubscribe:
http://mail.python.org/mailman/options/mailman-developers/archive%40jab.org
Security Policy: http://wiki.list.org/x/QIA9
