sumit goyal via Mailman-Developers writes:

 > While implementing this, I added support for displaying
 > list:member:generic:header and list:member:generic:footer in the UI,
 > assuming these are valid fallback templates used by Mailman Core.

grep -r is your friend.
You also need to know that Mailman doesn't provide for new templates;
the template names are more or less hardcoded into the workflow's
code.  There is no provision to register more.

You will discover that all references to "list:member:generic" are to
"list:member:generic:footer".  `../interfaces/template.py` will show
you how it is used.  There are several dozen references in the gettext
message catalogs, so you likely want to pipe through "grep -vF /messages/".

 > However, the CI pipeline is failing during tests that attempt to create
 > these templates via Mailman Core,

I'm not sure why an attempt to create "list:member:generic:header"
would fail, but "list:member:generic:footer" already exists, so an
attempt to create it would likely violate a database uniqueness
constraint.

For the convenience of reviewers, you should including links (not
screenshots) to the errors reported on GitLab.

 >    If not, should Postorius only reference them in documentation (as
 >    fallback behavior) without exposing them as selectable templates?

I'm not sure how the selectable templates are added to the database,
which is where Postorius would find them.  (Postorius would not know
where they are in the file system because the suite is designed so
that Postorius and HyperKitty can be hosted on different nodes from
Mailman core.)

If you are working on this for the GSoC qualifying MR, I recommend
that you do the documentation patch first, then work on the menu item
issue.


-- 
GNU Mailman consultant (installation, migration, customization)
Sirius Open Source    https://www.siriusopensource.com/
Software systems consulting in Europe, North America, and Japan
_______________________________________________
Mailman-Developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/mailman-developers.python.org/
Mailman FAQ: https://wiki.list.org/x/AgA3

Security Policy: https://wiki.list.org/x/QIA9

Reply via email to